[SPARK-58858] Add scg-config crate - #4
Closed
viirya wants to merge 1 commit into
Closed
Conversation
Part of importing the Spark Connect Gateway reference implementation into apache/spark-connect-gateway as a series of small, bottom-up PRs. This adds the scg-config crate — the YAML configuration layer for the gateway. It defines the config schema (deserialized with serde) and the loader that reads and validates the gateway's YAML configuration at startup. scg-config is a leaf crate (no internal dependencies), so it compiles and tests on its own (45 unit tests covering the schema and loader). It is appended to the workspace members list and is consumed later by the gateway binary. Co-authored-by: Claude Code
HyukjinKwon
approved these changes
Aug 19, 2026
Member
Author
|
Thanks @dongjoon-hyun @HyukjinKwon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Part of importing the Spark Connect Gateway reference implementation into
apache/spark-connect-gatewayas a series of small, bottom-up PRs (tracked inthe do-not-merge reference PR #1).
This adds the
scg-configcrate — the YAML configuration layer for the gateway.It defines the config schema (deserialized with serde) and the loader that reads
and validates the gateway's YAML configuration at startup.
scg-configis a leaf crate (no internal dependencies), so it compiles andtests on its own (45 unit tests covering the schema and loader). It is appended
to the workspace
memberslist and is consumed later by the gateway binary.Why are the changes needed?
Implements the reference gateway from the approved SPIP (SPARK-58455), imported
one reviewable piece at a time.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
cargo fmt --all --check,cargo clippy --workspace --all-targets -- -D warnings,cargo build --workspace, andcargo test --workspaceall pass locally(scg-config has 45 unit tests).
Was this patch authored or co-authored using generative AI tooling?
Yes, co-authored with Claude Code.